-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fedora 40 containerdisk #1202
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @brianmcarey @dhiller |
/retest |
It would be worth building a image and creating a test PR against kubevirt as this will likely break a number of network tests which I hit issues with previously trying to update this image to f39. I can try and get an image built for you. |
Running tests here - kubevirt/kubevirt#12105 |
@brianmcarey thank you! |
The new image provides an updated kernel which is needed for memory hotplug testing as virtio-mem requires the guest kernel to be 5.16+ at least. Signed-off-by: Antonio Cardace <[email protected]>
fd3d734
to
c79c240
Compare
@acardace: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Antonio, thanks for the PR
Can we update the image we using in kubevirt test to fedora 40 instead of introducing another fedora image?
https://github.com/kubevirt/kubevirtci/blob/main/cluster-provision/images/vm-image-builder/fedora-with-test-tooling/os-variant
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
The new image provides an updated kernel which is needed for memory hotplug testing as virtio-mem requires the guest kernel to be 5.16+ at least.
What this PR does / why we need it:
Add Fedora 40 to help with memory hotplug testing.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: