Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 40 containerdisk #1202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acardace
Copy link
Member

@acardace acardace commented Jun 12, 2024

The new image provides an updated kernel which is needed for memory hotplug testing as virtio-mem requires the guest kernel to be 5.16+ at least.

What this PR does / why we need it:
Add Fedora 40 to help with memory hotplug testing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Bump fedora-with-test-tooling image to Fedora 40

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 12, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ormergi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acardace
Copy link
Member Author

/cc @brianmcarey @dhiller

@acardace
Copy link
Member Author

/retest

@brianmcarey
Copy link
Member

brianmcarey commented Jun 12, 2024

It would be worth building a image and creating a test PR against kubevirt as this will likely break a number of network tests which I hit issues with previously trying to update this image to f39.
kubevirt/kubevirt#11419

I can try and get an image built for you.

@brianmcarey
Copy link
Member

Running tests here - kubevirt/kubevirt#12105

@acardace
Copy link
Member Author

@brianmcarey thank you!

The new image provides an updated kernel which is needed for memory
hotplug testing as virtio-mem requires the guest kernel to be 5.16+
at least.

Signed-off-by: Antonio Cardace <[email protected]>
@acardace acardace changed the title Bump fedora-with-test-tooling image to Fedora 40 Add Fedora 40 containerdisk Jun 17, 2024
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jun 17, 2024

@acardace: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu c79c240 link false /test check-up-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@ormergi ormergi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Antonio, thanks for the PR

Can we update the image we using in kubevirt test to fedora 40 instead of introducing another fedora image?
https://github.com/kubevirt/kubevirtci/blob/main/cluster-provision/images/vm-image-builder/fedora-with-test-tooling/os-variant

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants