Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check hashicorp: Add hashicorp whitelist #105

Closed
wants to merge 1 commit into from
Closed

check hashicorp: Add hashicorp whitelist #105

wants to merge 1 commit into from

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Sep 27, 2023 •
edited
Loading

What this PR does / why we need it:
Validates that no hashicorp are used beside the whitelisted ones
(because they shifted to BSL license)

Special notes for your reviewer:
Atm no hashicorp is used, but lets protect in case someone will add.
Based on the whitelist that CNAO uses.

Need to enable and validate git actions runs.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 27, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Sep 27, 2023 •
edited
Loading

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_macvtap-cni/105/pull-macvtap-cni-e2e-k8s/1706942466743078912

it uses latest kubevirtci and 1.24 which isn't included
#106

@maiqueb
Copy link
Collaborator

maiqueb commented Sep 27, 2023

Can you elaborate what this PR is about ?...

@oshoval
Copy link
Contributor Author

oshoval commented Sep 27, 2023

Can you elaborate what this PR is about ?...

please see k8snetworkplumbingwg/kubemacpool#394
will update soon PR desc, was meant to be draft meanwhile

@maiqueb
Copy link
Collaborator

maiqueb commented Sep 27, 2023

Can you elaborate what this PR is about ?...

please see k8snetworkplumbingwg/kubemacpool#394 will update soon PR desc, was meant to be draft meanwhile

Got better things to do right now. Will check once the proper information is available.

In the meanwhile, please make this a draft.

FWIW, I think the providers in this project must be synced - iiuc, it is using k8s-1.24, which I guess has been removed plenty of time ago.

@oshoval
Copy link
Contributor Author

oshoval commented Sep 27, 2023 •
edited
Loading

FWIW, I think the providers in this project must be synced - iiuc, it is using k8s-1.24, which I guess has been removed plenty of time ago.

already done #105 (comment)

@oshoval oshoval marked this pull request as draft September 27, 2023 08:15
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@oshoval oshoval marked this pull request as ready for review September 27, 2023 08:43
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Sep 27, 2023

Updated PR desc, note please that git actions should be enabled for this to run
no rush, whenever you have time please in case you want this protection,
we include it on all network repos

@oshoval oshoval marked this pull request as draft September 27, 2023 09:54
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@oshoval oshoval marked this pull request as ready for review September 27, 2023 10:12
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
phoracek
phoracek approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +1 to automating this instead of relying on people reviewing licenses

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@phoracek
Copy link
Member

phoracek commented Oct 3, 2023

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@phoracek
Copy link
Member

phoracek commented Oct 3, 2023

/lgtm

Holding for @maiqueb to give his approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@oshoval
Copy link
Contributor Author

oshoval commented Oct 9, 2023

Thanks
@maiqueb can you please take a look ?

maiqueb
maiqueb reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain where you got this whitelist from ?

@oshoval
Copy link
Contributor Author

oshoval commented Oct 26, 2023 •
edited
Loading

Could you explain where you got this whitelist from ?

all info here
kubevirt/cluster-network-addons-operator#1607

extract from go.mod, and check for each its lic / it is on exception list if needed

@oshoval oshoval requested a review from maiqueb November 2, 2023 08:52
@oshoval
Copy link
Contributor Author

oshoval commented Nov 12, 2023 •
edited
Loading

Note, currently there are no hashicorp used,
this will mainly protect about adding ones, while also whitelisting the ones that are known to be safe to use
(see exception file here)

We can close it if there is a lack of interest, or to include it with empty whitelist to just protect
against adding new ones

@oshoval oshoval mentioned this pull request Nov 12, 2023
Closed
@oshoval
Copy link
Contributor Author

oshoval commented Nov 19, 2023

/close

in case desired we can reopen

@oshoval oshoval closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@maiqueb maiqueb Awaiting requested review from maiqueb

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshoval @maiqueb @kubevirt-bot @phoracek