Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: Introduce test-subset plugin #3164

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Jan 11, 2024

Allows to run specific labels on a lane
/test-subset <job-name> <labels>

It will create a job, inject the label to its env var, and give it a unique suffix, so it won't
affect the official jobs.
Opposed to focus (which is also not encouraged, now that we have labels), the job won't fail if all lanes
pass, which reduce emails, comments, and the need to manually look on the job results on both cases.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 11, 2024
@oshoval oshoval changed the title external plugins: Introduce specify plugin plugins: Introduce specify plugin Jan 11, 2024
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@kubevirt-bot
Copy link
Contributor

@oshoval: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-prow-kubevirt-labels-update-precheck cb31120 link true /test pull-prow-kubevirt-labels-update-precheck
pull-prow-nmstate-labels-update-precheck cb31120 link true /test pull-prow-nmstate-labels-update-precheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oshoval
Copy link
Contributor Author

oshoval commented Mar 10, 2024

@oshoval: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-prow-kubevirt-labels-update-precheck cb31120 link true /test pull-prow-kubevirt-labels-update-precheck
pull-prow-nmstate-labels-update-precheck cb31120 link true /test pull-prow-nmstate-labels-update-precheck

how come it runs it on draft

@oshoval
Copy link
Contributor Author

oshoval commented Apr 7, 2024

/close

lets reopen once / if we are back to it

@oshoval oshoval closed this Apr 7, 2024
@oshoval oshoval reopened this Feb 3, 2025
@dhiller
Copy link
Contributor

dhiller commented Feb 3, 2025

/cc

@kubevirt-bot kubevirt-bot requested a review from dhiller February 3, 2025 14:45
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2025
@oshoval
Copy link
Contributor Author

oshoval commented Feb 13, 2025

resolved conflicts only

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign brianmcarey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Contributor Author

oshoval commented Feb 16, 2025

@brianmcarey @dhiller
before i rename it (anyhow it is still wip),
do you like the name Daniel suggest test-subset ?

btw, maybe better to consider a name without - ?
easier to trigger it, and maybe looks bit nicer on the manifests (but this is nit)

@oshoval oshoval force-pushed the specify branch 5 times, most recently from 8325bc5 to 2ad0387 Compare March 3, 2025 12:08
@dhiller
Copy link
Contributor

dhiller commented Mar 3, 2025

@brianmcarey @dhiller before i rename it (anyhow it is still wip), do you like the name Daniel suggest test-subset ?

btw, maybe better to consider a name without - ? easier to trigger it, and maybe looks bit nicer on the manifests (but this is nit)

IMHO the dash should stay for readability reasons, also it seems common practice to use it as can be seen on our command help page: https://prow.ci.kubevirt.io/command-help

@oshoval oshoval force-pushed the specify branch 2 times, most recently from b39e1fa to 5c15166 Compare March 3, 2025 15:13
@oshoval oshoval changed the title plugins: Introduce specify plugin plugins: Introduce test-subset plugin Mar 3, 2025
@oshoval
Copy link
Contributor Author

oshoval commented Mar 3, 2025

renamed

Allows to run specific labels on a lane
/test-subset <job-name> <labels>

It will create a job, inject the label to its env var,
and give it a unique suffix, so it won't
affect the official jobs.
Opposed to focus (which is also not encouraged, now that we have labels),
the job won't fail if all lanes pass, which reduce emails,
comments, and the need to manually look on the job results on both cases.

Signed-off-by: Or Shoval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants