-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: Introduce test-subset plugin #3164
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@oshoval: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
how come it runs it on draft |
/close lets reopen once / if we are back to it |
/cc |
resolved conflicts only |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@brianmcarey @dhiller btw, maybe better to consider a name without |
8325bc5
to
2ad0387
Compare
IMHO the dash should stay for readability reasons, also it seems common practice to use it as can be seen on our command help page: https://prow.ci.kubevirt.io/command-help |
Signed-off-by: Or Shoval <[email protected]>
b39e1fa
to
5c15166
Compare
renamed |
Allows to run specific labels on a lane /test-subset <job-name> <labels> It will create a job, inject the label to its env var, and give it a unique suffix, so it won't affect the official jobs. Opposed to focus (which is also not encouraged, now that we have labels), the job won't fail if all lanes pass, which reduce emails, comments, and the need to manually look on the job results on both cases. Signed-off-by: Or Shoval <[email protected]>
Allows to run specific labels on a lane
/test-subset <job-name> <labels>
It will create a job, inject the label to its env var, and give it a unique suffix, so it won't
affect the official jobs.
Opposed to focus (which is also not encouraged, now that we have labels), the job won't fail if all lanes
pass, which reduce emails, comments, and the need to manually look on the job results on both cases.