Skip to content

Conversation

@aburdenthehand
Copy link
Member

What this PR does / why we need it:

/hold
to allow for kubevirt/client-python#61 to be merged

As per the linked PR:
We've had a few folks on the mailing list have troubles with this, since it has not been maintained in a while but is automatically updated, which gives the appearance of the repo still being supported.

We had previously put a call out for maintainers for this repo but did not receive enough volunteers.

Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 26, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aglitke for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dhiller
Copy link
Contributor

dhiller commented Aug 27, 2025

Hey, @aburdenthehand! Thanks for raising this - indeed I believe this should be archived. However, we need to remove the client-python update from the release process: https://github.com/kubevirt/kubevirt/blob/main/automation/release.sh#L40

FYI @xpivarc @fossedihelm

@fossedihelm
Copy link
Contributor

fossedihelm commented Aug 27, 2025

Should we also remove the client generator?https://github.com/kubevirt/kubevirt/blob/654c1fd6aa0bb84bbc13fc6435adc01bada527d4/hack/gen-client-python/generate.sh ·

Edit:
in case we should also adjust project-infra https://github.com/search?q=org%3Akubevirt+%22make+client-python%22&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants