[release-v0.18] Alert VMStorageClassWarning only for Windows VMs

[machadovilaca]

What this PR does / why we need it:

This is a manual cherry-pick of #984

Which issue(s) this PR fixes:

Fixes #

jira-ticket: https://issues.redhat.com/browse/CNV-50785

Special notes for your reviewer:

Release note:

Alert VMStorageClassWarning only for Windows VMs

[sonarqubecloud]

Quality Gate failed

Failed conditions
5 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[machadovilaca]

/retest

[akrejcir]

Are you going to open a PR for later versions too?

[machadovilaca]

Are you going to open a PR for later versions too?

yes

[machadovilaca]

/hold

[sradco]

@machadovilaca what is the status of this PR?

[machadovilaca]

@machadovilaca what is the status of this PR?

due to the metrics bug in the kubevirt repo, the e2e tests here are failing, the fix was already merged, ill try again this later today

[machadovilaca]

/retest

[machadovilaca]

/retest

[akrejcir]

/retest

[machadovilaca]

/retest

[0xFelix]

check_committed_files seems to be unhappy.

[machadovilaca]

check_committed_files seems to be unhappy.

The logs for this run have expired and are no longer available.

can you try to rerun that test manually?

[0xFelix]

I don't see a way to retrigger the test.

Can you run hack/check-commited-changes.sh locally?

[0xFelix]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0xFelix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[machadovilaca]

/unhold

[sonarqubecloud]

Quality Gate failed

Failed conditions
5 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sradco]

/lgtm

[machadovilaca]

/cherry-pick release-v0.17

[kubevirt-bot]

@machadovilaca: #1126 failed to apply on top of branch "release-v0.17":

Applying: Alert VMStorageClassWarning only for Windows VMs
Using index info to reconstruct a base tree...
M	internal/operands/metrics/resources.go
M	tests/monitoring_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/monitoring_test.go
CONFLICT (content): Merge conflict in tests/monitoring_test.go
Auto-merging internal/operands/metrics/resources.go
CONFLICT (content): Merge conflict in internal/operands/metrics/resources.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Alert VMStorageClassWarning only for Windows VMs

In response to this:

/cherry-pick release-v0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[machadovilaca]

/cherry-pick release-v0.19

[kubevirt-bot]

@machadovilaca: #1126 failed to apply on top of branch "release-v0.19":

Applying: Alert VMStorageClassWarning only for Windows VMs
Using index info to reconstruct a base tree...
M	internal/operands/metrics/resources.go
M	tests/monitoring_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/monitoring_test.go
CONFLICT (content): Merge conflict in tests/monitoring_test.go
Auto-merging internal/operands/metrics/resources.go
CONFLICT (content): Merge conflict in internal/operands/metrics/resources.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Alert VMStorageClassWarning only for Windows VMs

In response to this:

/cherry-pick release-v0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[0xFelix]

Please don't foward backport something. Ideally this should have landed in release-v0.19 first, then in release-v0.18.