Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.16] deps: Update golang version to 1.19 #1268

Merged
merged 1 commit into from
Mar 10, 2025
Merged

[release-v0.16] deps: Update golang version to 1.19 #1268

merged 1 commit into from
Mar 10, 2025

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
This will allow update of some modules.

Special notes for your reviewer:
Downstream builds already use golang 1.19.
This PR will unblock: #1246

Release note:

None

@akrejcir
deps: Update golang version to 1.19
e3dffc3 
This will allow update of some modules.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 11, 2025
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @ksimon1

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@akrejcir
Copy link
Collaborator Author

/retest

@jcanocan
Copy link
Contributor

/retest-required

0xFelix
0xFelix reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@akrejcir
Copy link
Collaborator Author

/retest

@jcanocan
Copy link
Contributor

/retest-required

@akrejcir
Copy link
Collaborator Author

/retest

1 similar comment
@akrejcir
Copy link
Collaborator Author

/retest

@jcanocan
Copy link
Contributor

@akrejcir Did you try to run the e2e tests locally? These tests failed many times already.

@kubevirt-bot
Copy link
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Feb 21, 2025
@akrejcir
Copy link
Collaborator Author

akrejcir commented Mar 4, 2025

I've tried it locally, and all the tests passed.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Mar 4, 2025

/retest

2 similar comments
@akrejcir
Copy link
Collaborator Author

akrejcir commented Mar 5, 2025

/retest

@akrejcir
Copy link
Collaborator Author

akrejcir commented Mar 5, 2025

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 5, 2025

@akrejcir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-functests e3dffc3 link true /test e2e-upgrade-functests
ci/prow/e2e-functests e3dffc3 link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

0xFelix
0xFelix reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ksimon1
Copy link
Member

ksimon1 commented Mar 5, 2025

/override ci/prow/e2e-functests

@kubevirt-bot
Copy link
Contributor

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/e2e-functests

In response to this:

/override ci/prow/e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member

ksimon1 commented Mar 5, 2025

/override ci/prow/e2e-upgrade-functests

@kubevirt-bot
Copy link
Contributor

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/e2e-upgrade-functests

In response to this:

/override ci/prow/e2e-upgrade-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akrejcir
Copy link
Collaborator Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@akrejcir
Copy link
Collaborator Author

Self-approved, because Felix's approval was not registered.

@kubevirt-bot kubevirt-bot merged commit 010d323 into kubevirt:release-v0.16 Mar 10, 2025
10 checks passed
@akrejcir akrejcir deleted the update-golang-0.16 branch March 10, 2025 13:26
@kubevirt-bot
Copy link
Contributor

/remove-label needs-approver-review

@kubevirt-bot kubevirt-bot removed the needs-approver-review Indicates that a PR requires a review from an approver. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akrejcir @jcanocan @kubevirt-bot @ksimon1 @0xFelix