Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove code for updating from very old kubevirt-ssp-operator #1269

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
The repository https://github.com/kubevirt/kubevirt-ssp-operator has not been used for a long time. It is improbable that users would update a 4 year old cluster directly to this SSP version without intermediate updates.

Release note:

None

The repository https://github.com/kubevirt/kubevirt-ssp-operator
has not been used for a long time. It is improbable that users
would update a 4 year old cluster directly to this SSP version
without intermediate updates.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 11, 2025
@jcanocan
Copy link
Contributor

jcanocan commented Feb 11, 2025

Nice cleanup @akrejcir!
/lgtm
/retest-required

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@akrejcir
Copy link
Collaborator Author

/retest

1 similar comment
@akrejcir
Copy link
Collaborator Author

/retest

@akrejcir
Copy link
Collaborator Author

Weird, the CI is buggy. It says that golangci-lint timed out, but the timeout is set to 5 minutes and the CI fails after 2 minutes.

@akrejcir
Copy link
Collaborator Author

/retest

@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @codingben

@kubevirt-bot kubevirt-bot requested a review from 0xFelix February 14, 2025 13:33
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@kubevirt-bot kubevirt-bot merged commit fe6385f into kubevirt:main Feb 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants