Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Fix various issues found by code inspection #1278

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

cleanup: Fix various issues found by code inspection #1278

wants to merge 5 commits into from

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
Fixed:

  • Handle unhandled errors
  • Removed unused code
  • Stopped using deprecated methods
  • Code style issues

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 17, 2025
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @jcanocan

0xFelix
0xFelix reviewed Feb 17, 2025
View reviewed changes
tests/crypto_policy_test.go Outdated
@@ -204,7 +204,7 @@ func getCaCertificate() []byte {
func tryToAccessEndpoint(pod core.Pod, serviceName string, subpath string, port uint16, tlsConfig clientTLSOptions, insecure bool) (attemptedUrl string, err error) {
conn, err := portForwarder.Connect(&pod, port)
Expect(err).ToNot(HaveOccurred())
defer conn.Close()
defer Expect(conn.Close()).To(Succeed())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it run if another Expect fails?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will work. A panic can happen during panicking. They will just wrap around each other.
https://go.dev/play/p/Eq5sdpNkDl

@akrejcir akrejcir force-pushed the code-inspection-cleanup branch 2 times, most recently from c3d1c4b to 45c1ccc Compare February 17, 2025 14:52
@akrejcir
Copy link
Collaborator Author

In multiple PRs we have problem with the golangci-lint timeout. I will look into it...

@akrejcir
Copy link
Collaborator Author

/retest

1 similar comment
@akrejcir
Copy link
Collaborator Author

/retest

0xFelix
0xFelix reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 18, 2025
codingben
codingben approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@akrejcir Do you want to hold it until you get a response from @machadovilaca to your question about an unused function?

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 19, 2025
@akrejcir akrejcir force-pushed the code-inspection-cleanup branch from 45c1ccc to c7b19d4 Compare February 19, 2025 09:27
@kubevirt-bot kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 19, 2025
@akrejcir
Copy link
Collaborator Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
@akrejcir
Copy link
Collaborator Author

/retest

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@akrejcir akrejcir force-pushed the code-inspection-cleanup branch from c7b19d4 to d41c688 Compare February 24, 2025 12:54
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@jcanocan
Copy link
Contributor

/lgtm
/retest-required

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@akrejcir
Copy link
Collaborator Author

The failures were probably not flakes, but caused by this PR. I'm looking into it.

@akrejcir
functests: create port-forward connection in DialContext
08ea01e 
There are tests that check that invalid TLS connections are rejected.
When a connection is rejected, the client closes it.
This caused an error when the test code tried the close the connection
again.

This PR moves the creation of the connection to the DialContext function.
It is now managed by the HTTP client.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@kubevirt-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 25, 2025

@akrejcir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-single-node-functests 08ea01e link true /test e2e-single-node-functests
ci/prow/e2e-upgrade-functests 08ea01e link true /test e2e-upgrade-functests
ci/prow/e2e-functests 08ea01e link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@machadovilaca machadovilaca machadovilaca left review comments

@codingben codingben codingben approved these changes

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@codingben codingben

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akrejcir @kubevirt-bot @jcanocan @0xFelix @codingben @machadovilaca