fix!: Default to auditScanner.outputScan=false #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For big clusters with big (Cluster)PolicyReports, it is cost-prohibitive to print them as `info` logs in the auditScanner Jobs. Change `auditScanner.outputScan` as opt-in, with false as default. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
This is because of the change of auditScanner.outputScan to opt-in, false as default. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
jvanz
approved these changes
Feb 9, 2024
|
The new patch release of controller entails the following, which is all fine: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For big clusters with big (Cluster)PolicyReports, it is cost-prohibitive to print them as
infologs in the auditScanner Jobs.Change
auditScanner.outputScanas opt-in, with false as default.Bump kubewarden-controller chart to version
2.0.8.Test
CI
Additional Information
This is a breaking change. I have considered shipping it as a minor release instead and I am undecided. Nevertheless, it should be documented in changelog and notified.
Tradeoff
Potential improvement