fix: invalid audit scanner container command. #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory resource configuration for the audit scanner is wrong. The limit is less then the requested amount. This commit fixed that by inverting the quantities. Signed-off-by: José Guilherme Vanz <[email protected]>
The container command is an array of strings. The `--disable-store` flag value passed is `false` which fails. Because it is unmarshaled as boolean. To fix that, the helper code to build the command now only add the flag if the user want to disable the store. Otherwise, it does not add the CLI flag that. As the default value for the flag is "false" this does not change the audit scanner behaviour. Signed-off-by: José Guilherme Vanz <[email protected]>
fabriziosestito
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The container command is an array of strings. The
--disable-storeflag value passed isfalsewhich fails. Because it is unmarshaled as boolean. To fix that, the helper code to build the command must quote the boolean valueThe memory resource configuration for the audit scanner is wrong. The limit is less then the requested amount. This commit fixed that by inverting the quantities.
Fix #390