chore: kubewarden-crds version bump. #397
Conversation
Updates the appVersion of the kubewarden-crds chart to keep it in sync with the other charts. The version is now v1.11.0-rc3. The chart version also needs to be updated to release the chart. Signed-off-by: José Guilherme Vanz <[email protected]>
charts/kubewarden-crds/Chart.yaml
Outdated
| @@ -22,9 +22,9 @@ keywords: | |||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | |||
| version: 1.4.5 | |||
| version: 1.5.0-rc3 | |||
There was a problem hiding this comment.
This should be
| version: 1.5.0-rc3 | |
| version: 1.4.6.0-rc1 |
There was a problem hiding this comment.
I'll apply this change and keep the pattern used in the other charts as well. I don't know why, but yesterday when I reviewed the previous commits I saw a minor version bump. Maybe my brain was failing in the end of the day...
However, it looks weird to me a rc for a patch version bump. Maybe is another issue to be fixed in the automation tech-debt issues.
There was a problem hiding this comment.
I think it's fine to do a version patch bump. The contents of the chart haven't changed, no features added, only chart annotations changed, hence a patch bump.
There was a problem hiding this comment.
Both kubewarden-controller and kubewarden-defaults depend on kubewarden-crds. Since this kubewarden-crds bump doesn't have any changes, it will continue to work nevertheless. But I think we should to update their annotations too:
https://github.com/kubewarden/helm-charts/blob/main/charts/kubewarden-controller/Chart.yaml#L38
https://github.com/kubewarden/helm-charts/blob/main/charts/kubewarden-defaults/Chart.yaml#L39
Signed-off-by: José Guilherme Vanz <[email protected]>
Description
Updates the appVersion of the kubewarden-crds chart to keep it in sync with the other charts. The version is now v1.11.0-rc3. The chart version also needs to be updated to release the chart.
Fix #395