Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct key settings.allowPrivilegeEscalation #431

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Apr 18, 2024

Description

Test

Manually because of questions. For upgrade and clean installation.

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad requested a review from a team as a code owner April 18, 2024 09:10
@viccuad viccuad self-assigned this Apr 18, 2024
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the e2e tests are failing due the old field name. Maybe missing change somewhere?

@viccuad
Copy link
Member Author

viccuad commented Apr 18, 2024

The E2E tests do a helm upgrade --install --devel so they don't install this PR code, sadly. I think we should just remove them from PR runs and main, and only show them in cronjobs of rcs for now.

@jvanz
Copy link
Member

jvanz commented Apr 18, 2024

The E2E tests do a helm upgrade --install --devel so they don't install this PR code, sadly. I think we should just remove them from PR runs and main, and only show them in cronjobs of rcs for now.

Yeah, that's true. I forgot that. Sorry.

@viccuad viccuad merged commit 9e041c3 into kubewarden:main Apr 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants