feat: Use domain-qualified finalizer #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert 1580b68 'Revert the default policy server finalizer in use (kubewarden#468)'
|
@viccuad the diff looks strange, only the chart version is changed (going backwards). Can you explain what is going on please? |
|
@flavio Indeed, the version bump is wrong. It is also missing the actual revert, as it already is in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 1580b68 'Revert the default policy server finalizer in use (#468)'
Description
Bring back #460
Test
Tested on the original PR.
Additional Information
Tradeoff
Potential improvement