deps: Migrate to rancher/kuberlr-kubectl #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump rancher/kuberlr-kubectl instead of kubewarden/kubectl. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Instead of using a hardcoded kubectl version as we did with kubewarden/kubectl image, migrate to `kuberlr-kubectl`. kuberlr-kubectl image bundles several kubectl binaries that correspond with the Kubernetes versions supported by Rancher. This simplifies airgap installations. In addition, kuberlr-kubectl will download a matching kubectl binary if the Kubernetes API server is out of the Kubernetes version skew policy of the kubectl binaries it bundles. This ensures we always have a correct kubectl binary. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
flavio
approved these changes
Jan 8, 2025
The image ships with the correct non root user and the corresponding /etc/passwd & /etc/groups, yet one gets "Error: container has runAsNonRoot and image has non-numeric user (kuberlr), cannot verify user is non-root" if one doesn't set runAsUser,runAsGroup. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
flavio
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix kubewarden/kubewarden-controller#907
Test
E2E tests.
Additional Information
This PR bumps the kuberlr-kubectl image to v3.0.0. Once this is merged, I will have an eye for the updatecli automated bump to v4.0.0 as a means of testing that automation.
Tradeoff
Potential improvement