chore(qrm): NetworkManager add run interface

kubewharf · Feb 11, 2025 · 22012fb · 22012fb
1 parent d3ee958
commit 22012fb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/pkg/metaserver/external/manager_linux.go b/pkg/metaserver/external/manager_linux.go
@@ -69,6 +69,7 @@ func (m *externalManagerImpl) Run(ctx context.Context) {
 	m.start = true
 
 	go m.CgroupIDManager.Run(ctx)
+	go m.NetworkManager.Run(ctx)
 
 	m.mutex.Unlock()
 	<-ctx.Done()

diff --git a/pkg/util/external/network/manager.go b/pkg/util/external/network/manager.go
@@ -17,6 +17,7 @@ limitations under the License.
 package network
 
 import (
+	"context"
 	"sync"
 
 	"github.com/kubewharf/katalyst-core/pkg/util/cgroup/common"
@@ -33,6 +34,8 @@ type NetworkManager interface {
 	ClearNetClass(cgroupID uint64) error
 	// ApplyNetworkGroups apply parameters for network groups.
 	ApplyNetworkGroups(map[string]*qrmgeneral.NetworkGroup) error
+	// Run runs the network manager.
+	Run(ctx context.Context)
 }
 
 type NetworkManagerStub struct {
@@ -81,3 +84,5 @@ func (n *NetworkManagerStub) ClearNetClass(cgroupID uint64) error {
 func (n *NetworkManagerStub) ApplyNetworkGroups(map[string]*qrmgeneral.NetworkGroup) error {
 	return nil
 }
+
+func (n *NetworkManagerStub) Run(ctx context.Context) {}
diff --git a/pkg/util/external/network/manager_linux.go b/pkg/util/external/network/manager_linux.go
@@ -20,6 +20,7 @@ limitations under the License.
 package network
 
 import (
+	"context"
 	"errors"
 
 	"github.com/kubewharf/katalyst-core/pkg/util/cgroup/common"
@@ -40,7 +41,7 @@ func (*defaultNetworkManager) ApplyNetClass(podUID, containerId string, data *co
 }
 
 // ListNetClass lists the net class config for all containers managed by kubernetes.
-func (m *defaultNetworkManager) ListNetClass() ([]*common.NetClsData, error) {
+func (n *defaultNetworkManager) ListNetClass() ([]*common.NetClsData, error) {
 	// TODO: implement traffic tagging by using eBPF
 	return nil, errors.New("not implemented yet")
 }
@@ -55,3 +56,5 @@ func (*defaultNetworkManager) ClearNetClass(cgroupID uint64) error {
 func (n *defaultNetworkManager) ApplyNetworkGroups(map[string]*qrmgeneral.NetworkGroup) error {
 	return nil
 }
+
+func (n *defaultNetworkManager) Run(ctx context.Context) {}
diff --git a/pkg/util/external/network/manager_unsupported.go b/pkg/util/external/network/manager_unsupported.go
@@ -20,6 +20,8 @@ limitations under the License.
 package network
 
 import (
+	"context"
+
 	"github.com/kubewharf/katalyst-core/pkg/util/cgroup/common"
 )
 
@@ -44,3 +46,5 @@ func (*unsupportedNetworkManager) ListNetClass() ([]*common.NetClsData, error) {
 func (*unsupportedNetworkManager) ClearNetClass(cgroupID uint64) error {
 	return nil
 }
+
+func (*unsupportedNetworkManager) Run(ctx context.Context) {}