add comments for pool-related functions

kubewharf · Dec 12, 2023 · b414c26 · b414c26
1 parent 55d6a6d
commit b414c26
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/pkg/agent/qrm-plugins/cpu/dynamicpolicy/state/util.go b/pkg/agent/qrm-plugins/cpu/dynamicpolicy/state/util.go
@@ -226,6 +226,7 @@ func GetPoolType(poolName string) string {
 	}
 }
 
+// GetSpecifiedPoolName todo: this function (along with pool-name consts) should be moved to generic qos conf
 func GetSpecifiedPoolName(qosLevel, cpusetEnhancementValue string) string {
 	switch qosLevel {
 	case apiconsts.PodAnnotationQoSLevelSharedCores:

diff --git a/pkg/agent/qrm-plugins/cpu/dynamicpolicy/state/util_test.go b/pkg/agent/qrm-plugins/cpu/dynamicpolicy/state/util_test.go
@@ -506,11 +506,13 @@ func TestGenerateCPUMachineStateByPodEntries(t *testing.T) {
 
 		as.Equalf(tc.expectedMachineState, machineState, "failed in test case: %s", tc.description)
 
-		os.RemoveAll(tmpDir)
+		_ = os.RemoveAll(tmpDir)
 	}
 }
 
 func TestGetSpecifiedPoolName(t *testing.T) {
+	t.Parallel()
+
 	type args struct {
 		qosLevel               string
 		cpusetEnhancementValue string

diff --git a/pkg/config/generic/qos.go b/pkg/config/generic/qos.go
@@ -365,14 +365,12 @@ func (c *QoSConfiguration) GetSpecifiedPoolNameForPod(pod *v1.Pod) (string, erro
 // GetSpecifiedPoolName returns the specified cpuset pool name for given enhancements and annotations;
 func (c *QoSConfiguration) GetSpecifiedPoolName(enhancements, annotations map[string]string) (string, error) {
 	qosLevel, err := c.GetQoSLevel(annotations)
-
 	if err != nil {
 		return "", fmt.Errorf("GetQoSLevel failed with error: %v", err)
 	}
 
 	enhancementKVs := helper.ParseKatalystQOSEnhancement(enhancements, annotations,
 		apiconsts.PodAnnotationCPUEnhancementKey)
-
 	return state.GetSpecifiedPoolName(qosLevel, enhancementKVs[apiconsts.PodAnnotationCPUEnhancementCPUSet]), nil
 }