chore(*): log clean up - log level downgraded to 6 for detailed and lengthy lines #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-w-chen
force-pushed
the
dev/log-cleanup
branch
from
7232e04 to
51b1d2c
Compare
h-w-chen
changed the title
h-w-chen
force-pushed
the
dev/log-cleanup
branch
from
51b1d2c to
9a51efa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
==========================================
- Coverage 60.78% 60.58% -0.20%
==========================================
Files 603 604 +1
Lines 63248 63373 +125
==========================================
- Hits 38443 38397 -46
- Misses 20970 21126 +156
- Partials 3835 3850 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luomingmeng
approved these changes
Feb 11, 2025
gary-lgy
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement - log cleanup
What this PR does / why we need it:
downgrade log level to 6 for those extreme long log details. 6 is chosen as the current convention in code indicates 6 is the lest one printing out json encode response in get devices function