Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): emit metrics for out-of-date/missing malachite data #773

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

gary-lgy
Copy link
Member

@gary-lgy gary-lgy commented Feb 5, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (fb6d1d8) to head (5b0fc00).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...tric/provisioner/malachite/client/client_cgroup.go 93.47% 2 Missing and 1 partial ⚠️
...tric/provisioner/malachite/client/client_system.go 81.25% 2 Missing and 1 partial ⚠️
...tric/provisioner/malachite/realtime_provisioner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   60.78%   60.61%   -0.18%     
==========================================
  Files         603      603              
  Lines       63248    63316      +68     
==========================================
- Hits        38443    38376      -67     
- Misses      20970    21095     +125     
- Partials     3835     3845      +10     
Flag Coverage Δ
unittest 60.61% <90.27%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gary-lgy gary-lgy force-pushed the malachite-outdated-metrics branch 3 times, most recently from 6eb5137 to 46abfd3 Compare February 6, 2025 10:16
@gary-lgy gary-lgy force-pushed the malachite-outdated-metrics branch from 46abfd3 to 5b0fc00 Compare February 6, 2025 10:47
@gary-lgy gary-lgy changed the title feat(metrics): emit metrics for outdated/missing malachite data feat(metrics): emit metrics for out-of-date/missing malachite data Feb 10, 2025
@gary-lgy gary-lgy merged commit 24c642f into kubewharf:main Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants