Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining unsafe indexes to safe indexes except File #175

Merged
merged 7 commits into from
Mar 30, 2025

Conversation

kubkon
Copy link
Owner

@kubkon kubkon commented Mar 29, 2025

This finishes migration of remaining indexes to safe indexes with the exception of File which will be done in a follow-up.

As an interesting observation, I believe that thanks to the rewrite of indexes, bold got a tiny bit faster, dropping below 1s when linking Zig's stage3 compiler (I have used an old setup for Zig so your mileage may vary when tested against up-to-date Zig repo!). Anyhow, the results:

Screenshot 2025-03-29 at 06 46 30

Note that now we've got only Apple rewritten ld to beat!

@kubkon kubkon marked this pull request as ready for review March 29, 2025 05:49
@kubkon kubkon merged commit 67148a8 into main Mar 30, 2025
4 checks passed
@kubkon kubkon deleted the more-safe-indexes branch March 30, 2025 04:20
@kubkon
Copy link
Owner Author

kubkon commented Mar 30, 2025

This finishes migration of remaining indexes to safe indexes with the exception of File which will be done in a follow-up.

As an interesting observation, I believe that thanks to the rewrite of indexes, bold got a tiny bit faster, dropping below 1s when linking Zig's stage3 compiler (I have used an old setup for Zig so your mileage may vary when tested against up-to-date Zig repo!). Anyhow, the results:
Screenshot 2025-03-29 at 06 46 30

Note that now we've got only Apple rewritten ld to beat!

Actually, I wonder if the speed-up is due to zig-yaml partial rewrite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant