Add JSON-schema export (KEP-35 part 2) #1727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]> # Conflicts: # pkg/kudoctl/cmd/package_list_params.go
…he package format Signed-off-by: Andreas Neumann <[email protected]>
Make sure topLevelGroups are required if they have required properties without defaults Updated generated files Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Adjusted json schema for schemas Added tests Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
Signed-off-by: Andreas Neumann <[email protected]> # Conflicts: # config/crds/kudo.dev_operatorversions.yaml # pkg/kudoctl/cmd/testdata/deploy-kudo-ns.yaml.golden # pkg/kudoctl/cmd/testdata/deploy-kudo-sa.yaml.golden # pkg/kudoctl/cmd/testdata/deploy-kudo.json.golden # pkg/kudoctl/cmd/testdata/deploy-kudo.yaml.golden # pkg/kudoctl/kudoinit/crd/bindata.go
Signed-off-by: Andreas Neumann <[email protected]>
|
@ANeumann82 is this ready for review? |
It's been a while, but yeah, I think this was ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for output types in
kudo package list parameters:kudo package list parameters --output yaml--> Outputs the package format of params.yamlkudo package list parameters --output json-schema--> Outputs the parameters converted to JSON-Schema