Merge pull request #193 from kufu/fixes/trophy_job_skip_qe_trigger

Skip empty condition trigger, there is QR trigger.
kufu · May 14, 2024 · 49e501d · 49e501d
2 parents 3f85f9e + d341c13
commit 49e501d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/app/jobs/trophy_job.rb b/app/jobs/trophy_job.rb
@@ -4,8 +4,14 @@ class TrophyJob < ApplicationJob
   queue_as :default
 
   def perform(profile)
-    Trigger.where('description LIKE ?', 'trophy:%').each do |trigger|
+    Trigger.where('description LIKE ?', 'trophy:%').order(description: :asc).each do |trigger|
+      logger.info("Trigger: #{trigger.description}")
+      next if trigger.conditions.empty?
+
       trigger.perform(profile, 'trophy')
     end
+  rescue Trigger::TriggerError, StandardError => e
+    logger.error(e)
+    raise e
   end
 end