Skip empty condition trigger, there is QR trigger.

kufu · May 14, 2024 · 69349fe · 69349fe
1 parent 61d83a5
commit 69349fe
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/app/jobs/trophy_job.rb b/app/jobs/trophy_job.rb
@@ -4,8 +4,15 @@ class TrophyJob < ApplicationJob
   queue_as :default
 
   def perform(profile)
-    Trigger.where('description LIKE ?', 'trophy:%').each do |trigger|
+    Trigger.where('description LIKE ?', 'trophy:%').order(description: :asc).each do |trigger|
+      next if trigger.conditions.empty?
       trigger.perform(profile, 'trophy')
     end
+  rescue Trigger::TriggerError => e
+    Rails.logger.error(e)
+    raise e
+  rescue StandardError => e
+    Rails.logger.error(e)
+    raise e
   end
 end