Merge pull request #205 from kufu/fixes/string_compare_condition

Fix a bug Condition's includes action returns false positive when empty array,

app/models/trigger/condition.rb

@@ -108,9 +108,7 @@ def count_check(num, operator)
     end
 
     def includes_check(includes)
-      resolve_model_attribute.each do |obj|
-        return false unless includes.include?(obj)
-      end
+      resolve_model_attribute.any? { |obj| includes.include?(obj) }
     end
   end
 end

test/models/trigger/condition_test.rb

@@ -377,9 +377,23 @@ class ConditionTest < ActiveSupport::TestCase
       assert_not condition.satisfy?
     end
 
-    test '#satisfy? returns true when include action chain methods' do
-      Friend.create!(from: profiles(:profile_one).id, to: profiles(:profile_two).id)
+    test '#satisfy? returns false when include action(with empty array)' do
+      condition = Trigger::Condition.new(
+        {
+          model: 'Friend',
+          target: 'Profile',
+          props: {
+            from: 'target'
+          },
+          action: { 'includes' => [profiles(:profile_three).id], 'attribute' => 'to' }
+        },
+        profiles(:profile_one)
+      )
+
+      assert_not condition.satisfy?
+    end
 
+    test '#satisfy? returns false when include action chain methods' do
       condition = Trigger::Condition.new(
         {
           model: 'Friend',
@@ -392,7 +406,7 @@ class ConditionTest < ActiveSupport::TestCase
         profiles(:profile_one)
       )
 
-      assert condition.satisfy?
+      assert_not condition.satisfy?
     end
 
     test '#satisfy? returns true when include action chain methods with eager loading' do