Skip to content

Commit

Permalink
Use <button type="button"> instead of <a href="#">
Browse files Browse the repository at this point in the history
  • Loading branch information
@kinoppyd
kinoppyd committed Aug 21, 2024
1 parent 4340c31 commit b01d6a5
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions app/views/members/dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@

<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
</div>
</div>
<% end %>
</dialog>
</dialog>
2 changes: 1 addition & 1 deletion app/views/plans/_description_dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/plans/_password_dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</div>
<div class="flex flex-col border-t border-[rgb(214,211,208)] py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.make_editable'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/plans/_rename_dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/plans/_setting_dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</div>
<div class="flex flex-col border-t border-[rgb(214,211,208)] py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/profiles/_dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/views/profiles/show.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
</div>
</div>
</dialog>
Expand Down Expand Up @@ -89,7 +89,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
</div>
</div>
</dialog>
Expand Down
2 changes: 1 addition & 1 deletion app/views/schedules/_card.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/teams/_rename_dialog.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
<div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
<div class="flex justify-end">
<a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
<button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
<%= f.submit I18n.t('button.save'), data: { action: "click->dialog#disable", "word-counter-target": "submit" }, class: "primary-button" %>
</div>
</div>
Expand Down

0 comments on commit b01d6a5

Please sign in to comment.