Friends #184
Merged
Friends #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ikuta
reviewed
May 10, 2024
| @@ -29,11 +29,37 @@ | |||
| </button> | |||
| <%= render 'dialog', profile: @profile %> | |||
| </div> | |||
| <% if @user.admin? %> | |||
There was a problem hiding this comment.
すみません仕様をよく分かっていないのですが、adminじゃないとQRコードを表示できない仕様でしょうか？
There was a problem hiding this comment.
すみません、説明不足でした！！！
これはリリースをRubyKaigiDay0に合わせたいなと思って塞いでいます、Day0の日にこのコミットをRevertして全員に使えるようにしようと思います
|
[nice to have] |
e-ikuta
reviewed
May 10, 2024
| <div class="flex flex-wrap ml-6 mb-4"> | ||
| <% @user.profile.friend_profiles.each do |profile| %> | ||
| <% if @friends_schedules_map[profile.id].include?(row.tracks[track].id) %> | ||
| <img src="<%= profile.avatar_url %>" class="h-8 w-8 rounded-full border-2 border-black mt-[-4px] ml-[-16px] mt-1" /> |
There was a problem hiding this comment.
モバイルだとスケジュールに友達のアイコンが表示されませんでした。これから対応予定でしたらすみません🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friends
Implementation of friends feature.