Realtime trophy check #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinoppyd
force-pushed
the
features/auto_trophy
branch
from
d7e0bd7
to
7dca512
Compare
kinoppyd
force-pushed
the
features/auto_trophy
branch
from
7dca512
to
b7d188a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SolidQueue and new ActiveJob "TrophyJob" to check person has right to get new trophy.
Check by Trigger::Condition, new class for Trigger. Condition defines how to manipulate ApplicationRecord subclasses and how to compare values. TrophyJob checks Trigger's condition then fire trigger.
トロフィの獲得をチェックするために、新たにSolidQueueとTrophyJobを追加しました。
トロフィの獲得条件は、Triggerの新しいクラスであるConditionによりチェックされます。Conditionは、ApplicationRecordのサブクラスから値を取得する操作方法と、値の比較方法を定義します。TrophyJobは、Conditionを全てパスしたTriggerを発火させることで、トロフィを付与します。