docs: Input と CurrencyInput、SearchInput の Story を見直し #5029
+407
−362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uknmr
commented
Oct 18, 2024
| React.ComponentProps<typeof Input>, | ||
| 'type' | 'value' | 'defaultValue' | 'placeholder' | ||
| > & { | ||
| type Props = Omit<React.ComponentProps<typeof Input>, 'type' | 'value' | 'defaultValue'> & { |
There was a problem hiding this comment.
placeholder は Input で定義されていたので消しました。
|
|
||
| const VRT = {} | ||
|
|
||
| export const VRTHover: StoryObj<typeof SearchInput> = { |
There was a problem hiding this comment.
addon-pseudo-states では再現できなさそうだったため play function を利用（focus も同じ
uknmr
force-pushed
the
improve-Input-story
branch
from
26aea79
to
e23bc51
Compare
commit: |
| subcomponents: { CurrencyInput, SearchInput }, | ||
| // eslint-disable-next-line smarthr/a11y-input-in-form-control | ||
| render: (args) => <Input {...args} />, | ||
| args: {}, |
There was a problem hiding this comment.
ReactNode を受けると props についてはデフォ値を設定するか、args の型を定義しないと Playground で [Set Object] 押下するとクラッシュしちゃいますね…。
s-sasaki-0529
requested changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
#4949 の方針に沿って Input や CurrencyInput、SearchInput の Story を見直しました。
変更内容
確認方法
Storybook や Chromatic で確認してください。