-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: CheckBox の Story を見直し #5031
base: master
Are you sure you want to change the base?
Conversation
checked: true, | ||
mixed: true, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixed は checked ありきなので、ここだけ input 要素の props を指定しちゃってます。
commit: |
const mixed = [true, false] | ||
const error = [true, false] | ||
const disabled = [true, false] | ||
const checked = [true, false] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled / checked は Input 側の props だけど見た目に大きく影響を与えるので網羅します。
...VRT, | ||
parameters: { | ||
pseudo: { | ||
hover: ['.smarthr-ui-CheckBox-checkBox'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo: VRT と VRTHover、VRTFocusVisible を一つの Story にまとめてしまっても良いかもと思いました。
export const Playground: StoryObj<typeof CheckBox> = { | ||
args: {}, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked とdisabled は input の機能ですが、主要な props だと思うので Story を作っても良さそうに思いました。
関連URL
概要
#4949 の方針に沿って、Checkbox の Story を見直しました。
(優先度的には Table が先だけど、 TdCheckbox とか含まれるから先に Checkbox やったほうが良さそうと判断)
変更内容
確認方法
Storybook や Chromatic で確認してください。