docs(ErrorScreen): Storybook を見直し #5145
Merged
+135
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
s-sasaki-0529
commented
Nov 28, 2024
|
|
||
| const logoOptions = { | ||
| デフォルト: undefined, | ||
| ReactNode: <div>ロゴ</div>, |
There was a problem hiding this comment.
ロゴ部分にデフォルトの SmartHR ロゴ以外に何を出す需要があるのか良くわからず・・。
適当に div 要素を埋め込めんでしまいましたが、何か適切なサンプルありますかね…？
There was a problem hiding this comment.
There was a problem hiding this comment.
グループ会社など SmartHR 以外のプロダクトでロゴを出す可能性があります。ここは例として SmartHR のロゴが出てても問題ないように思いました!
s-sasaki-0529
commented
Nov 28, 2024
| { label: 'お問い合わせ', url: '/contact' }, | ||
| ], | ||
| }, | ||
| } |
There was a problem hiding this comment.
このコンポーネントはフルスクリーンで表示される都合、並べて表示することができないので、一通りの項目が表示されるパターン1個で担保します。props 同士がバッティングすることもないのでまぁ。
s-sasaki-0529
requested review from
yt-ymmt,
moshisora,
Qs-F,
misako0927 and
uknmr
and removed request for
a team
uknmr
approved these changes
Nov 28, 2024
|
|
||
| const logoOptions = { | ||
| デフォルト: undefined, | ||
| ReactNode: <div>ロゴ</div>, |
There was a problem hiding this comment.
グループ会社など SmartHR 以外のプロダクトでロゴを出す可能性があります。ここは例として SmartHR のロゴが出てても問題ないように思いました!
uknmr
reviewed
Nov 28, 2024
packages/smarthr-ui/src/components/ErrorScreen/stories/VRTErrorScreen.stories.tsx
Outdated
Show resolved
Hide resolved
…rScreen.stories.tsx Co-authored-by: KANAMORI Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1133
概要
変更内容
確認方法
Storybook や Chromatic で確認してください。