chore: Tooltipの内部ロジックをリファクタリングする #5245
Open
+120
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtsushiM
commented
Jan 9, 2025
Comment on lines
-102
to
-104
| const getHandlerToShow = useCallback( | ||
| <T,>(handler?: (e: T) => void) => | ||
| (e: T) => { |
There was a problem hiding this comment.
もともとの方法では 関数を返す関数 をmemo化していました。
共通化以上の意味が薄く、関数も毎回生成されるので以下のように修正しました
- 共通ロジックを切り出して
ellipsisOnlyが変更されない限り再生成されないように修正 - 上記共通ロジックを使ったonXxxx毎の関数をmemo化
これにより適切にメモ化されるようになり、基本的な使い方をしている限り、関数が再生成されないようになっています
AtsushiM
commented
Jan 9, 2025
| const hiddenText = useMemo(() => innerText(message), [message]) | ||
| const isIcon = triggerType === 'icon' | ||
| const styles = tooltip({ isIcon, className }) | ||
| const styles = useMemo(() => tooltip({ isIcon, className }), [isIcon, className]) |
There was a problem hiding this comment.
tailwindのstyle生成も再レンダリング毎に再生成されていたのでmemo化しています
AtsushiM
commented
Jan 9, 2025
|
|
||
| const getHandlerToHide = useCallback( |
There was a problem hiding this comment.
こちらも関数を返す関数になっていたため、onXxxx毎にmemo化する方法に変更しています
yagimushi
force-pushed
the
chore-memoized-Tooltip
branch
from
d7a953e to
0c59d1b
Compare
AtsushiM
commented
Jan 9, 2025
| @@ -70,7 +70,7 @@ export const Tooltip: FC<Props & ElementProps> = ({ | |||
| children, | |||
| triggerType, | |||
| multiLine, | |||
| ellipsisOnly = false, | |||
There was a problem hiding this comment.
比較処理しかしておらず、booleanが型として必要な箇所もなかったため、undefinedのままでも問題になる可能性はありませんでした
yagimushi
force-pushed
the
chore-memoized-Tooltip
branch
2 times, most recently
from
0c495fd to
505e51f
Compare
commit: |
yagimushi
force-pushed
the
chore-memoized-Tooltip
branch
10 times, most recently
from
b2abd7e to
505e51f
Compare
yagimushi
force-pushed
the
chore-memoized-Tooltip
branch
from
89966da to
e1a7afc
Compare
AtsushiM
requested review from
misako0927 and
yuzuru-akiyama
and removed request for
a team
masa0527
reviewed
Feb 21, 2025
Comment on lines
+138
to
+139
| const calcedResponseStatus = useResponseMessage(responseMessage) | ||
|
|
There was a problem hiding this comment.
calcedはcalculatedってことですかね？ぱっと見読み取れなかった
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法