Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cookie handling #37

Merged
merged 6 commits into from
Dec 6, 2023
Merged

feat: added cookie handling #37

merged 6 commits into from
Dec 6, 2023

Conversation

philprime
Copy link
Collaborator

No description provided.

@philprime philprime self-assigned this Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

Warnings
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against ebdb958

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7a33ab6) 57.89% compared to head (16f5f57) 58.32%.

Files Patch % Lines
Sources/Postie/Cookies/RequestCookies.swift 42.85% 4 Missing ⚠️
Sources/Postie/Cookies/ResponseCookies.swift 84.61% 2 Missing ⚠️
Sources/Postie/Encoder/RequestEncoding.swift 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   57.89%   58.32%   +0.42%     
==========================================
  Files          63       65       +2     
  Lines        1577     1610      +33     
==========================================
+ Hits          913      939      +26     
- Misses        664      671       +7     
Flag Coverage Δ
unittests 58.32% <79.41%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philprime philprime merged commit 4f1752a into main Dec 6, 2023
5 checks passed
@philprime philprime deleted the feature/cookies branch December 6, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants