Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avus with integers #10

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Fix avus with integers #10

merged 8 commits into from
Mar 5, 2024

Conversation

montesmariana
Copy link
Collaborator

No description provided.

@montesmariana montesmariana marked this pull request as draft March 5, 2024 11:09
@montesmariana montesmariana requested a review from rmoreas March 5, 2024 12:09
@montesmariana montesmariana marked this pull request as ready for review March 5, 2024 12:10
@rmoreas
Copy link
Collaborator

rmoreas commented Mar 5, 2024

Besides remarks about %-formatting for logging, it looks good to me.

Adding a test for the creation of the log message, would make it perfect ;-)

Can be done with assetLog context manager: https://docs.python.org/3.9/library/unittest.html#unittest.TestCase.assertLogs

@montesmariana
Copy link
Collaborator Author

Besides remarks about %-formatting for logging, it looks good to me.

Adding a test for the creation of the log message, would make it perfect ;-)

Can be done with assetLog context manager: https://docs.python.org/3.9/library/unittest.html#unittest.TestCase.assertLogs

Sounds great but I'll create an issue for it and do it in a later PR, because I need to get this out soon. Thank you!!

@montesmariana montesmariana reopened this Mar 5, 2024
@montesmariana montesmariana merged commit 11a63cd into main Mar 5, 2024
26 checks passed
@montesmariana montesmariana deleted the fix-avus-with-integers branch March 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants