Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): add support for inbound rules in inspect-api #12713

Merged
merged 15 commits into from
Feb 26, 2025

Conversation

lobkovilya
Copy link
Contributor

Motivation

#12560 added a new field InboundRules to FromRules structure:

type FromRules struct {
	// Rules is a map of InboundListener to a list of rules built by using 'spec.from' field.
	// Deprecated: use InboundRules instead
	Rules map[InboundListener]Rules
	// InboundRules is a map of InboundListener to a list of inbound rules built by using 'spec.rules' field.
	InboundRules map[InboundListener][]*inbound.Rule
}

this structure needs to be visible in the Inspect API /_rules endpoint.

Implementation information

It's a draft PR, at this moment only OpenAPI is changed.

Supporting documentation

Fix #12381

Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
@lobkovilya lobkovilya marked this pull request as ready for review February 3, 2025 09:36
@lobkovilya lobkovilya requested a review from a team as a code owner February 3, 2025 09:36
@Icarus9913
Copy link
Contributor

Looks good to me

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@lobkovilya lobkovilya merged commit a05674e into kumahq:master Feb 26, 2025
13 checks passed
@lobkovilya lobkovilya deleted the feat/inspect-api-support-rules branch February 26, 2025 17:08
lobkovilya added a commit that referenced this pull request Feb 28, 2025
…rom_as_rules` (#12979)

## Motivation

Renamed the descriptor field in my previous
[PR](#12713) but missed these policy
markers.

---------

Signed-off-by: Ilya Lobkov <[email protected]>
@lukidzi lukidzi changed the title feat(inspect-api): support for inbound rules feat(api-server): add support for inbound rules in inspect-api Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspect API support for the new spec.rules field
5 participants