-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-server): add support for inbound rules in inspect-api #12713
Merged
lobkovilya
merged 15 commits into
kumahq:master
from
lobkovilya:feat/inspect-api-support-rules
Feb 26, 2025
Merged
feat(api-server): add support for inbound rules in inspect-api #12713
lobkovilya
merged 15 commits into
kumahq:master
from
lobkovilya:feat/inspect-api-support-rules
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <[email protected]>
johncowen
reviewed
Jan 30, 2025
lahabana
reviewed
Jan 30, 2025
lahabana
reviewed
Jan 30, 2025
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Looks good to me |
lahabana
reviewed
Feb 24, 2025
...data/resources/inspect/dataplanes/_rules/dataplane_kind_meshtimeout_section_name.golden.json
Show resolved
Hide resolved
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
lahabana
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
lobkovilya
added a commit
that referenced
this pull request
Feb 28, 2025
…rom_as_rules` (#12979) ## Motivation Renamed the descriptor field in my previous [PR](#12713) but missed these policy markers. --------- Signed-off-by: Ilya Lobkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#12560 added a new field
InboundRules
toFromRules
structure:this structure needs to be visible in the Inspect API
/_rules
endpoint.Implementation information
It's a draft PR, at this moment only OpenAPI is changed.
Supporting documentation
Fix #12381