Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RHS transformer #19

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Adding RHS transformer #19

wants to merge 23 commits into from
+324 −16

Conversation

andyhuang-kumo
Copy link
Contributor

@andyhuang-kumo andyhuang-kumo commented Aug 12, 2024 •
edited
Loading

Adding RHS transformer to Hybrid GNN repo

  • extracting the relative time requires specific function for each dataset, currently not implemented.
  • clean up and improve rerank_transformer
  • Temporal Encoder now has absolute and fuse as options for temporal encoding, fuse concatenate and normalizes relative hour, day and week
  • rhstransformer supported in benchmark/relbench_link_prediction_benchmark.py
  • RHSTransformer implemented in hybridgnn/nn/models/RHSTransformer.py, attends to IDGNN rhs embeddings only

@andyhuang-kumo andyhuang-kumo requested a review from rusty1s August 12, 2024 18:57
zechengz
zechengz reviewed Aug 12, 2024
View reviewed changes
hybridgnn/nn/models/transformer.py Outdated Show resolved Hide resolved
hybridgnn/nn/models/transformer.py Outdated Show resolved Hide resolved
rusty1s
rusty1s reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the sorting logic. Eventually, I don't think we need a full replicate of HybridGNN module but merge it into the existing one. Okay though for testing purposes.

hybridgnn/nn/models/hybrid_rhstransformer.py Outdated Show resolved Hide resolved
hybridgnn/nn/models/transformer.py Outdated Show resolved Hide resolved
hybridgnn/nn/models/transformer.py Outdated Show resolved Hide resolved
hybridgnn/nn/models/transformer.py Outdated Show resolved Hide resolved
hybridgnn/nn/models/transformer.py Show resolved Hide resolved
@andyhuang-kumo
adding transformer changes
d6ff169
@andyhuang-kumo
permute the index, the rhs and then reverse it
4884b83
@andyhuang-kumo
removing none to replace with None
08041cb
@andyhuang-kumo
add time fuse encoder to extract time pe
29c70ad
@andyhuang-kumo
update hyperparameter options
f58b528
@andyhuang-kumo
adding rerank_transformer
8f4966c
@andyhuang-kumo
setting zeros for not used logits in rerank transformer
90a8817
@andyhuang-kumo
adding reranker transformer
1eb769c
@andyhuang-kumo
Merge branch 'master' into rhs_tr
ea58dd0
@andyhuang-kumo
updating RHS transformer code
75445ce
@andyhuang-kumo
updating rerank_transformer
7380a17
@andyhuang-kumo
push current version
7622b94
@andyhuang-kumo
converging to the follow implementation
dc73f7c 
 Please enter the commit message for your changes. Lines starting
@andyhuang-kumo
training both from epoch 0, potentially try better ways
38f9cf4
@andyhuang-kumo
for transformer, not training with nodes whose prediction is not within
8e846dd 
topk
@andyhuang-kumo
commiting before clean up
41a38cf
@andyhuang-kumo
clean up, removing reference to rerank transformer
3e71188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zechengz zechengz zechengz left review comments

@rusty1s rusty1s rusty1s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyhuang-kumo @rusty1s @zechengz