Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the need to explicitly import JoinMeta #61

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

eboody
Copy link
Contributor

@eboody eboody commented Dec 5, 2024

It's pretty un-intuitive to need to import JoinMeta in my opinion.

This PR just adds a use statement in the quote! so that people don't have to know that they need to import it.

Thoughts?

@eboody
Copy link
Contributor Author

eboody commented Dec 6, 2024

@kurtbuilds

whoops!

I didnt realize i could just test and sticking a use statement in the quote! was dumb. but i figured it out!

I went ahead and just changed the necessary invocation of ._id() in core/src/join.rs to use the fully qualified path. like thing._id() -> ormlite_core::join::JoinMeta::_id(thing).

that seems to have done the trick @kurtbuilds

@kurtbuilds
Copy link
Owner

Nice! I agree that's a cleaner way to do it.

I think you might have mixed up the git history, as now these PRs include the derive-enum logic.

Why did you create derive enum as a separate crate instead of including it in the existing ormlite-derive crate? My intuition is that's a more logical home for it.

@eboody
Copy link
Contributor Author

eboody commented Dec 6, 2024

oh! i dunno why i thought each proc macros had to be in their own separate crate. oops. youre absolutely right. i'll get the derive enum thing out of this as well as put it in the macro crate

@eboody
Copy link
Contributor Author

eboody commented Dec 6, 2024

there we go :) @kurtbuilds

@eboody
Copy link
Contributor Author

eboody commented Dec 6, 2024

@kurtbuilds the master branch wont pass just test in the same way this wont. do you know about that?

@kurtbuilds
Copy link
Owner

Yeah, I think I committed a new feature for pg that spilled onto sqlite that's causing the failing. Plan to fix this weekend.

@eboody
Copy link
Contributor Author

eboody commented Jan 10, 2025

bump!

@kurtbuilds
Copy link
Owner

thank you for the bump. master tests are fixed, this just had a async_trait import remaining to be removed.

@kurtbuilds kurtbuilds merged commit 1237aa9 into kurtbuilds:master Jan 11, 2025
1 check passed
@kurtbuilds
Copy link
Owner

published as 0.22.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants