-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the need to explicitly import JoinMeta #61
Conversation
whoops! I didnt realize i could I went ahead and just changed the necessary invocation of that seems to have done the trick @kurtbuilds |
Nice! I agree that's a cleaner way to do it. I think you might have mixed up the git history, as now these PRs include the derive-enum logic. Why did you create derive enum as a separate crate instead of including it in the existing ormlite-derive crate? My intuition is that's a more logical home for it. |
oh! i dunno why i thought each proc macros had to be in their own separate crate. oops. youre absolutely right. i'll get the derive enum thing out of this as well as put it in the macro crate |
there we go :) @kurtbuilds |
@kurtbuilds the master branch wont pass |
Yeah, I think I committed a new feature for pg that spilled onto sqlite that's causing the failing. Plan to fix this weekend. |
bump! |
thank you for the bump. master tests are fixed, this just had a |
published as 0.22.9. |
It's pretty un-intuitive to need to import JoinMeta in my opinion.
This PR just adds a use statement in the quote! so that people don't have to know that they need to import it.
Thoughts?