Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

feat: add the Istio labels for baseline Services and Deployments #8

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

leoporoli
Copy link
Collaborator

No description provided.

Copy link

gitguardian bot commented Oct 16, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13106060 Triggered Generic High Entropy Secret 96dbf66 ci/obd-demo.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@leoporoli leoporoli requested a review from laurentluce October 16, 2024 20:52
@leoporoli leoporoli force-pushed the lporoli/setting-istio-labels branch from f427d28 to c63fd7f Compare October 17, 2024 13:02
@leoporoli leoporoli force-pushed the lporoli/setting-istio-labels branch from c63fd7f to 9d1fe3e Compare October 17, 2024 13:16
kardinal/reconciler/reconciler.go Outdated Show resolved Hide resolved
@leoporoli leoporoli merged commit fe5a044 into main Oct 17, 2024
4 of 5 checks passed
@leoporoli leoporoli deleted the lporoli/setting-istio-labels branch October 17, 2024 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants