Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

chore: Refactor apply resources functions #9

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Conversation

laurentluce
Copy link
Collaborator

@laurentluce laurentluce commented Oct 17, 2024

Divide by three the number of lines required to support reconciling a new kardinal-managed resource type.

Copy link

gitguardian bot commented Oct 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13106060 Triggered Generic High Entropy Secret 312c730 ci/obd-demo.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@laurentluce laurentluce requested a review from leoporoli October 18, 2024 01:56
@laurentluce
Copy link
Collaborator Author

The linter is crashing in CI, will debug more tomorrow morning.

@laurentluce laurentluce merged commit 21bdbf9 into main Oct 18, 2024
5 checks passed
@leoporoli leoporoli deleted the laurent/refactoring branch October 18, 2024 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants