Skip to content

Commit

Permalink
ci: use a constant for tilt releaser and document why (#1952)
Browse files Browse the repository at this point in the history
  • Loading branch information
h4ck3rk3y authored Dec 14, 2023
1 parent f96ac6a commit 12ff56e
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,9 @@ parameters:
reverse-proxy-entrypoint-web-port:
type: string
default: "9730"
tilt-releaser-version:
type: string
default: "31e51c6441faa5021a20ebe84cf974145d2975f792dd880a5d1c2fa578818458"



Expand Down Expand Up @@ -470,10 +473,11 @@ jobs:
- "<< pipeline.parameters.engine-server-image-filename >>"

build_cli:
# we use this docker/tilt-releaser image for cli jobs because starlark-lsp requires it to build
# as opposed to running image off cimg/go:<< pipeline.parameters.go-version like every other job
# The starlark-lsp uses treesitter which has direct c bindings; and making a go releaser cross arch build
# requires a lot of tooling; when the original author adding starlark-lsp to the project they copied the tilt-releaser
# which came with all of the underlying tooling instead of bundling their own image; perhaps due to time constraints
docker:
- image: "docker/tilt-releaser@sha256:31e51c6441faa5021a20ebe84cf974145d2975f792dd880a5d1c2fa578818458"
- image: "docker/tilt-releaser@sha256:<< pipeline.parameters.tilt-releaser-version >>"
resource_class: large
steps:
- checkout
Expand Down Expand Up @@ -1201,8 +1205,11 @@ jobs:
push_cli_artifacts:
# we use this docker/tilt-releaser image for cli jobs because starlark-lsp requires it to build
# as opposed to running image off cimg/go:<< pipeline.parameters.go-version like every other job
# The starlark-lsp uses treesitter which has direct c bindings; and making a go releaser cross arch build
# requires a lot of tooling; when the original author adding starlark-lsp to the project they copied the tilt-releaser
# which came with all of the underlying tooling instead of bundling their own image; perhaps due to time constraints
docker:
- image: "docker/tilt-releaser@sha256:31e51c6441faa5021a20ebe84cf974145d2975f792dd880a5d1c2fa578818458"
- image: "docker/tilt-releaser@sha256:<< pipeline.parameters.tilt-releaser-version >>"
steps:
- slack/notify:
channel: engineering
Expand Down

0 comments on commit 12ff56e

Please sign in to comment.