Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ambiguity from the pvc names #1998

Closed
barnabasbusa opened this issue Dec 21, 2023 · 2 comments · Fixed by #2006 or #2023
Closed

Remove ambiguity from the pvc names #1998

barnabasbusa opened this issue Dec 21, 2023 · 2 comments · Fixed by #2006 or #2023
Assignees
@h4ck3rk3y
Labels
bug Something isn't working frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend nice to have Nice to have feature

Comments

@barnabasbusa
Copy link
Collaborator

What's your CLI version?

0.85.53

Description & steps to reproduce

When I create a new pvc with persistent volumes in kubernetes, I get random pvc names.

k -n kt-bitter-river get pvc
NAME                                                            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
enclave-data                                                    Bound    pvc-c79fde18-dc50-4611-ae6b-b547e799d786   1Gi        RWO            hostpath       8m23s
service-persistent-directory-716dde3efcfe39cc9e6c7d4a596ca0eb   Bound    pvc-f9d54b5b-2e80-4e70-ac4f-b4e95480b21f   1Gi        RWO            hostpath       6m6s
service-persistent-directory-d06739f2d83303f42d83f3fd34477985   Bound    pvc-cae66c5f-e737-4dbd-b858-98113e88aec1   1Gi        RWO            hostpath       6m17s
service-persistent-directory-d92433dfcc7b10c1b69b5d8d752b35d9   Bound    pvc-521ea91f-9d50-478e-9620-d95a6743824d   1Gi        RWO            hostpath       5m48s

Desired behavior

Ideally you would want to have the persistent_key as the name for the pvc.

Currently you can only find this with pvc describe:

k -n kt-bitter-river describe pvc service-persistent-directory-716dde3efcfe39cc9e6c7d4a596ca0eb
Name:          service-persistent-directory-716dde3efcfe39cc9e6c7d4a596ca0eb
Namespace:     kt-bitter-river
StorageClass:  hostpath
Status:        Bound
Volume:        pvc-f9d54b5b-2e80-4e70-ac4f-b4e95480b21f
Labels:        kurtosistech.com/app-id=kurtosis
               kurtosistech.com/enclave-id=2fc69ee037e64f25991462b819906a44
               kurtosistech.com/guid=716dde3efcfe39cc9e6c7d4a596ca0eb
               kurtosistech.com/id=cl-2-prysm-geth

found under kurtosistech.com/id=cl-2-prysm-geth

What is the severity of this bug?

Critical; I am blocked and Kurtosis is unusable for me because of this bug.

What area of the product does this pertain to?

Frontend: the Graphical User Interface, including the Enclave Manager
@barnabasbusa barnabasbusa added the bug Something isn't working label Dec 21, 2023
@github-actions github-actions bot added critical Critical bug or feature frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend labels Dec 21, 2023
@h4ck3rk3y h4ck3rk3y self-assigned this Dec 21, 2023
@h4ck3rk3y h4ck3rk3y added nice to have Nice to have feature and removed critical Critical bug or feature labels Dec 21, 2023
@h4ck3rk3y
Copy link
Contributor

Confirmed with Barnabas on chat this is a "nice to have"; totally empathise with randomly named things being painful

@barnabasbusa barnabasbusa mentioned this issue Dec 21, 2023
Merged
@h4ck3rk3y h4ck3rk3y mentioned this issue Jan 2, 2024
Merged
@h4ck3rk3y
Copy link
Contributor

This should get merged on Monday, which is a breaking change day!

github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
@h4ck3rk3y
fix!: change persistent directory name to deterministic value (#2006)
fa08707 
Closes #1998
@kurtosisbot kurtosisbot mentioned this issue Jan 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
@kurtosisbot
chore(main): release 0.86.0 (#2023)
3988fe3 
🤖 I have created a release *beep* *boop*
---


##
[0.86.0](0.85.56...0.86.0)
(2024-01-08)


### ⚠ BREAKING CHANGES

* allow to mount multiple artifacts to the same folder in a service.
Users will need to replace the `Directory.artifac_name` field key with
`Directory.artifac_names`
([#2025](#2025))
* change persistent directory name to deterministic value
([#2006](#2006))

### Features

* allow to mount multiple artifacts to the same folder in a service.
Users will need to replace the `Directory.artifac_name` field key with
`Directory.artifac_names`
([#2025](#2025))
([b51df93](b51df93))
* emui design updates
([#2028](#2028))
([0e480cf](0e480cf))
* Engine Traefik Docker labels for REST API reverse proxy routing
([#2019](#2019))
([6541884](6541884))


### Bug Fixes

* change persistent directory name to deterministic value
([#2006](#2006))
([fa08707](fa08707)),
closes [#1998](#1998)
* log streaming resource leaks
([#2026](#2026))
([7f8db9b](7f8db9b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
@kurtosisbot kurtosisbot mentioned this issue Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h4ck3rk3y h4ck3rk3y

Labels
bug Something isn't working frontend Label for issues (bugs, FRs, etc) that pertain to the Kurtosis frontend nice to have Nice to have feature
Projects
None yet
Milestone
No milestone
2 participants
@h4ck3rk3y @barnabasbusa