Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: change persistent directory name to deterministic value #2006

Merged
merged 15 commits into from
Jan 8, 2024
Merged

fix!: change persistent directory name to deterministic value #2006

merged 15 commits into from
Jan 8, 2024

Conversation

h4ck3rk3y
Copy link
Contributor

Closes #1998

@h4ck3rk3y
Copy link
Contributor Author

Need to add a validator that asserts 1035!

@h4ck3rk3y h4ck3rk3y changed the title fix: change persistent directory name to sdp-persistent-key-perisstent-hash fix!: change persistent directory name to sdp-persistent-key-perisstent-hash Jan 2, 2024
@h4ck3rk3y
Copy link
Contributor Author

@leoporoli this is WIP but this is technically a breaking change as earlier persitent_data would be a valid key but now as we label the pvc with the persitent_key it has to be 1035 comptaible(as we enforce this on all object names)

there is an argument to be made that the user shouldn't be using kubectl get pvc --all-namespaces and use KT instead; but this doesn't seem that harmful and this is what we already do for service names

@h4ck3rk3y h4ck3rk3y marked this pull request as draft January 2, 2024 12:56
@h4ck3rk3y h4ck3rk3y added the DO NOT MERGE DO NOT MERGE THIS PR label Jan 3, 2024
@h4ck3rk3y h4ck3rk3y marked this pull request as ready for review January 3, 2024 10:58
@h4ck3rk3y h4ck3rk3y changed the title fix!: change persistent directory name to sdp-persistent-key-perisstent-hash fix!: change persistent directory name to deterministic value Jan 5, 2024
@h4ck3rk3y h4ck3rk3y force-pushed the gyani/persistent-directory-name branch from ec45e2a to 80ab065 Compare January 5, 2024 14:31
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f322c5c
Status: ✅  Deploy successful!
Preview URL: https://2abf4007.kurtosis-docs.pages.dev
Branch Preview URL: https://gyani-persistent-directory-n.kurtosis-docs.pages.dev

View logs

@h4ck3rk3y h4ck3rk3y removed the DO NOT MERGE DO NOT MERGE THIS PR label Jan 8, 2024
@h4ck3rk3y h4ck3rk3y enabled auto-merge January 8, 2024 09:29
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Jan 8, 2024
@h4ck3rk3y h4ck3rk3y removed this pull request from the merge queue due to a manual request Jan 8, 2024
@h4ck3rk3y h4ck3rk3y enabled auto-merge January 8, 2024 11:18
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit fa08707 Jan 8, 2024
36 checks passed
@h4ck3rk3y h4ck3rk3y deleted the gyani/persistent-directory-name branch January 8, 2024 11:59
@kurtosisbot kurtosisbot mentioned this pull request Jan 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2024
@kurtosisbot
chore(main): release 0.86.0 (#2023)
3988fe3 
🤖 I have created a release *beep* *boop*
---


##
[0.86.0](0.85.56...0.86.0)
(2024-01-08)


### ⚠ BREAKING CHANGES

* allow to mount multiple artifacts to the same folder in a service.
Users will need to replace the `Directory.artifac_name` field key with
`Directory.artifac_names`
([#2025](#2025))
* change persistent directory name to deterministic value
([#2006](#2006))

### Features

* allow to mount multiple artifacts to the same folder in a service.
Users will need to replace the `Directory.artifac_name` field key with
`Directory.artifac_names`
([#2025](#2025))
([b51df93](b51df93))
* emui design updates
([#2028](#2028))
([0e480cf](0e480cf))
* Engine Traefik Docker labels for REST API reverse proxy routing
([#2019](#2019))
([6541884](6541884))


### Bug Fixes

* change persistent directory name to deterministic value
([#2006](#2006))
([fa08707](fa08707)),
closes [#1998](#1998)
* log streaming resource leaks
([#2026](#2026))
([7f8db9b](7f8db9b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
@kurtosisbot kurtosisbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoporoli leoporoli leoporoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ambiguity from the pvc names
2 participants
@h4ck3rk3y @leoporoli