Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved log experience on the UI. #1368

Merged
merged 5 commits into from
Sep 25, 2023
Merged

feat: improved log experience on the UI. #1368

merged 5 commits into from
Sep 25, 2023

Conversation

Peeeekay
Copy link
Contributor

@Peeeekay Peeeekay commented Sep 25, 2023 •
edited
Loading

This PR:
I have the logging experience now, where users can see large amount of logs. It behaves like terminal where if at bottom it automatically tracks the new logs, otherwise stays in place until user goes to bottom.

I have included copy and download functionality as well, where users can do that for service logs and logs generated during enclave creation.

@Peeeekay Peeeekay changed the title improved log experience on the UI feat: improved log experience on the UI. Sep 25, 2023
adschwartz
adschwartz suggested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@adschwartz adschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to roll out this change, but there are some things we can do to avoid adding (non-needed) tech-debt. Happy to give it another pass when you have updates. Thanks!

tedim52
tedim52 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@tedim52 tedim52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @Peeeekay . Jus a few comments

@Peeeekay Peeeekay requested a review from adschwartz September 25, 2023 18:31
adschwartz
adschwartz reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@adschwartz adschwartz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some additional comments. I would address those but removing my request for changes to unlock the PR

@Peeeekay Peeeekay force-pushed the pk/improve_logs_flow branch from 9cbfba8 to b4ebe64 Compare September 25, 2023 19:28
@Peeeekay Peeeekay merged commit 760c7f0 into main Sep 25, 2023
@Peeeekay Peeeekay deleted the pk/improve_logs_flow branch September 25, 2023 20:21
@kurtosisbot kurtosisbot mentioned this pull request Sep 25, 2023
Merged
Peeeekay pushed a commit that referenced this pull request Sep 25, 2023
@kurtosisbot
chore(main): release 0.83.7 (#1372)
dd0ebde 
🤖 I have created a release *beep* *boop*
---


##
[0.83.7](0.83.6...0.83.7)
(2023-09-25)


### Features

* improved log experience on the UI.
([#1368](#1368))
([760c7f0](760c7f0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedim52 tedim52 tedim52 approved these changes

@adschwartz adschwartz adschwartz approved these changes

Assignees
No one assigned
Labels
user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Peeeekay @adschwartz @tedim52