fix: restart log aggregator on failure #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
approved these changes
Sep 26, 2023
adschwartz
pushed a commit
that referenced
this pull request
Sep 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.83.9](0.83.8...0.83.9) (2023-09-26) ### Bug Fixes * rebuild with type bug fix ([#1385](#1385)) ([14840b7](14840b7)) * restart log aggregator on failure ([#1371](#1371)) ([7f171ce](7f171ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adjusts the log aggregator container configuration so that it's Docker always restarts the container when it detects it has exited with non-zero exit code. It also improves how we handle errors related to log aggregator not existing when creating an enclave.
This is a bandaid that should address #1311 but doesn't address the issue entirely. More context in issue's discussion.
Is this change user facing?
YES (users should not experience #1311 anymore)
References (if applicable):
#1311