chore: Simplify enclave-manager-sdk typescript dependencies #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dartoxian
changed the title
adschwartz
reviewed
Oct 19, 2023
Dartoxian
force-pushed
the
bg/enclave-manager-api-deps
branch
from
3c7f83c to
ffcc5f3
Compare
|
@adschwartz thanks for the call earlier, I've now tested this PR inside a locally built kurtosis engine and confirmed it's working. |
|
Another tweak to the |
adschwartz
approved these changes
Oct 23, 2023
|
@Dartoxian I'm ok with this if you have tested it and it works. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
## Description: This PR contains the beginnings of the new enclave manager ui. Specifically it adds a new project in `enclave-manager/web`. Notable inclusions: * Continuing to use Chakra as a component libary, the KurtosisThemeProvider injects components themed based on the mocks. * The enclave manager sdk cllient is refactored into authenticated (remote) and local versions, and provided to react components with `useKurtosisClient` by the `KurtosisClientProvider`. This provider blocks loading the application (with a spinner) until it's configured the client to use. * react router is used to compose the application. * react-table is used to create a (reusable) table for showing the enclaves list. ### Demo (WIP) https://github.com/kurtosis-tech/kurtosis/assets/4419574/c026a1d9-313d-4e73-944a-2814399e039a ## Is this change user facing? NO (this is not yet part of the build/deploy process) ## References (if applicable): This PR is rebased on top of #1595 which should be merged first. --------- Co-authored-by: Anders Schwartz <[email protected]> Co-authored-by: Anders Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The enclave manager sdk has a large number of (I think) unnecessary dependencies, this PR removes a lot of them and tidies up package.json.
Additionally, specify
yarn --frozen-lockfilein theenclave-manager/api/typescript/scripts/build.shso that builds will fail if dependencies are not committed properly.This change removes the dependency in the enclave manager from the general typescript
kurtosis-sdk- I'm not sure why this dependency is present as it's not required by any code generated by the enclave-manager-sdk.Is this change user facing?
NO
References (if applicable):
N/A