feat: user-configurable labels (in ServiceConfig type) for Docker containers and k8s pods #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
changed the title
Deploying with
|
| Latest commit: |
e2d55df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d84332c.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://lporoli-ticket-1585.kurtosis-docs.pages.dev |
|
@h4ck3rk3y it seems a big PR, but most of the files were updated because I moved one file from one package to another. |
|
@leeederek I added you for Docs review |
leeederek
suggested changes
Oct 23, 2023
h4ck3rk3y
approved these changes
Oct 24, 2023
...lib/lib/backend_impls/docker/object_attributes_provider/docker_label_key/docker_label_key.go
Outdated
Show resolved
Hide resolved
...lib/lib/backend_impls/docker/object_attributes_provider/docker_label_key/docker_label_key.go
Outdated
Show resolved
Hide resolved
...ib/backend_impls/docker/object_attributes_provider/docker_label_key/docker_label_key_test.go
Show resolved
Hide resolved
…s_provider/docker_label_key/docker_label_key.go Co-authored-by: Gyanendra Mishra <[email protected]>
leeederek
approved these changes
Oct 25, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.13](0.84.12...0.84.13) (2023-10-25) ### Features * user-configurable labels (in ServiceConfig type) for Docker containers and k8s pods ([#1604](#1604)) ([e98cdf6](e98cdf6)) ### Bug Fixes * name temporary python script for run_python with suitable name ([#1616](#1616)) ([88edb39](88edb39)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
user-configurable labels (in ServiceConfig type) for Docker containers and K8s pods
Is this change user facing?
YES
References (if applicable):
Fix #1585