-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: some fix for flaky tests #1750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
force-pushed
the
lporoli/detecting-flaky-tests-xlarge
branch
from
November 13, 2023 13:29
111d585
to
8b49566
Compare
Continuity seems to fail still |
@h4ck3rk3y that error is related to this: https://kurtosistech.slack.com/archives/C04HLLL98J2/p1700165857744079 so, yeap I'll wait for that fix and I'll merge it here, then we can try again |
@h4ck3rk3y now it's ready |
adschwartz
reviewed
Nov 17, 2023
adschwartz
approved these changes
Nov 17, 2023
leoporoli
changed the title
chore: testing flaky test in a xlarge box
chore: some fix for flaky tests
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
some fix for flaky tests
Is this change user facing?
NO
References (if applicable):
More here: https://www.notion.so/kurtosistech/Flaky-tests-analysis-094fef0f64be428c9cd32b49c1c94f9e