chore: revert EM UI build changes #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Nov 16, 2023
adschwartz
changed the title
adschwartz
changed the title
Dartoxian
added a commit
that referenced
this pull request
Nov 17, 2023
This reverts commit 76029c8.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
## Description: This PR brings the emui into the ci build/release process. It is a reversion of last nights #1813. Yesterday the build/release change for emui was abandoned because after several attempts the publish step was not working. In 4ed9328 I have demonstrated that this pr works by: * Removing the body of the publish jobs and replacing them with echo statements * Triggering publish jobs on `bgazzard-*` tags * Pushing a tag `bgazzard-0.0.1` (which I have now deleted) to trigger the `publish` workflow * The publish workflow can be seen here https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/9407/workflows/ca6cef3b-4f71-481a-ab08-8787002ed9d0 and demonstrates that the `build_enclave_manager_webapp` job is now successfully run as a dependency of `publish_engine_server_image`. The existing build/test path which was approved previously is unchanged by this pr and can be seen working in this workflow https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/9408/workflows/bb48e469-2ff7-433e-8da9-ad32620b0bbc. ## Is this change user facing? NO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reverts the changes to the enclave build process