Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emui handle json/yaml input interchangably #1891

Merged
merged 11 commits into from
Dec 5, 2023
Merged

feat: emui handle json/yaml input interchangably #1891

merged 11 commits into from
Dec 5, 2023

Conversation

Dartoxian
Copy link
Contributor

Description:

This PR adds support for using yaml in the json code editor input boxes. Demo below

yamldemo.mp4

Is this change user facing?

YES

References (if applicable):

  • Discussed on slack.

@Dartoxian Dartoxian requested a review from adschwartz December 5, 2023 11:17
adschwartz
adschwartz approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@adschwartz adschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but with one comment to look at

@Dartoxian Dartoxian enabled auto-merge December 5, 2023 14:08
@Dartoxian Dartoxian added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit cd4263b Dec 5, 2023
33 checks passed
@Dartoxian Dartoxian deleted the bgazzard/handle-yaml-json branch December 5, 2023 14:49
This was referenced Dec 5, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2023
@kurtosisbot
chore(main): release 0.85.41 (#1894)
eeb304b 
🤖 I have created a release *beep* *boop*
---


##
[0.85.41](0.85.40...0.85.41)
(2023-12-05)


### Features

* emui design improvements
([#1892](#1892))
([9268a24](9268a24))
* emui handle json/yaml input interchangably
([#1891](#1891))
([cd4263b](cd4263b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
@kurtosisbot kurtosisbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adschwartz adschwartz adschwartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dartoxian @adschwartz