Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emui design improvements #1892

Merged
merged 8 commits into from
Dec 5, 2023
Merged

feat: emui design improvements #1892

merged 8 commits into from
Dec 5, 2023

Conversation

Dartoxian
Copy link
Contributor

Description:

This PR implements several pieced of feedback from design:

  • Fix value card background colour (was 1 shade off)
  • Stronger starlark run progress colours
  • Fix catalog search input appearance and find keybinding
  • Pick up catalog images
  • Match breadcrumbs to designs

Demo including these features

simplescreenrecorder-2023-12-05_14.16.20.mp4

Is this change user facing?

YES

References (if applicable):

  • Figma

@Dartoxian Dartoxian added the DO NOT MERGE DO NOT MERGE THIS PR label Dec 5, 2023
@Dartoxian Dartoxian requested a review from adschwartz December 5, 2023 14:24
@Dartoxian Dartoxian removed the DO NOT MERGE DO NOT MERGE THIS PR label Dec 5, 2023
@Dartoxian Dartoxian added this pull request to the merge queue Dec 5, 2023
@Dartoxian Dartoxian removed this pull request from the merge queue due to a manual request Dec 5, 2023
@Dartoxian Dartoxian enabled auto-merge December 5, 2023 14:57
@Dartoxian Dartoxian added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 9268a24 Dec 5, 2023
33 checks passed
@Dartoxian Dartoxian deleted the bgazzard/emui-tweaks branch December 5, 2023 15:49
@kurtosisbot kurtosisbot mentioned this pull request Dec 5, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2023
@kurtosisbot
chore(main): release 0.85.41 (#1894)
eeb304b 
🤖 I have created a release *beep* *boop*
---


##
[0.85.41](0.85.40...0.85.41)
(2023-12-05)


### Features

* emui design improvements
([#1892](#1892))
([9268a24](9268a24))
* emui handle json/yaml input interchangably
([#1891](#1891))
([cd4263b](cd4263b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
@kurtosisbot kurtosisbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adschwartz adschwartz adschwartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dartoxian @adschwartz