feat: Reverse proxy lifecycle management and connectivity on Docker #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iner into consideration.
…dy taken ips so there is no conflict with the APIC or user service.
… old enclave ci test for now.
laurentluce
commented
Dec 6, 2023
laurentluce
commented
Dec 6, 2023
...gine-lib/lib/backend_impls/docker/docker_kurtosis_backend/backend_creator/backend_creator.go
Outdated
Show resolved
Hide resolved
laurentluce
commented
Dec 6, 2023
container-engine-lib/lib/backend_interface/objects/reverse_proxy/reverse_proxy_config.go
Outdated
Show resolved
Hide resolved
laurentluce
commented
Dec 7, 2023
...ib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go
Outdated
Show resolved
Hide resolved
…ce uuid and service port.
tedim52
reviewed
Dec 8, 2023
...ainer-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend.go
Show resolved
Hide resolved
tedim52
reviewed
Dec 8, 2023
...kend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_api_container_functions.go
Show resolved
Hide resolved
tedim52
reviewed
Dec 8, 2023
...ib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go
Outdated
Show resolved
Hide resolved
tedim52
approved these changes
Dec 8, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.43](0.85.42...0.85.43) (2023-12-11) ### Features * Add new ports view to the EM UI ([#1919](#1919)) ([027d74b](027d74b)) * add REST API bindings for TS and Golang ([#1907](#1907)) ([97b9b80](97b9b80)) * add support for public ports ([#1905](#1905)) ([97a3d95](97a3d95)) * enable building images in docker [image building pt. 1] ([#1911](#1911)) ([c153873](c153873)) * Reverse proxy lifecycle management and connectivity on Docker ([#1906](#1906)) ([69c5b27](69c5b27)) * service logs full download ([#1895](#1895)) ([b91333f](b91333f)) * Unified REST API ([c3911f6](c3911f6)) ### Bug Fixes * add installation description for oapi-codegen ([#1917](#1917)) ([8f2427b](8f2427b)) * Fix doc checker CI ([#1912](#1912)) ([cc2696d](cc2696d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
## Description: Docker Traefik is currently configured to route traffic based on three custom headers: enclave short uuid, service short uuid and port number. This type of routing rule is not possible with the K8S Ingress provider so we are switching to use the single Host header instead with the format: `<port number>-<service short uuid>-<enclave short uuid>`. ## Is this change user facing? NO ## References (if applicable): #1906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In #1871 we added the Traefik labels to the user services so Traefik can discover them and route to them. This PR implements a reverse proxy using Traefik on Docker. The engine starts and stops Traefik. The Traefik container is automatically connected to the enclave networks. The implementation leverages what was done for the logs aggregator.
Is this change user facing?
YES
References (if applicable):
#1871