feat: image build spec #1964

tedim52 · 2023-12-15T05:52:47Z

Description:

This changes adds the ImageBuildSpec built in type that can be used to build images in Kurtosis packages.
eg.

def run(plan, args):
    plan.add_service(
        name="server",
        config=ServiceConfig(
            image=ImageBuildSpec(
                image_name="server",
                build_context_dir="./server",
            ),
        ....
        ))

Is this change user facing?

YES

...ainer-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend.go

cloudflare-workers-and-pages · 2023-12-19T03:36:02Z

Deploying with Cloudflare Pages

Latest commit:	`825ba6f`
Status:	✅ Deploy successful!
Preview URL:	https://269f4d1e.kurtosis-docs.pages.dev
Branch Preview URL:	https://tedi-image-build-spec.kurtosis-docs.pages.dev

View logs

container-engine-lib/lib/user_support_constants/user_support_constants.go

container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go

container-engine-lib/lib/user_support_constants/user_support_constants.go

...server/api_container/server/startosis_engine/kurtosis_types/service_config/service_config.go

internal_testsuites/golang/testsuite/startosis_package_test/startosis_image_build_test.go

leoporoli

LGTM

🤖 I have created a release *beep* *boop* --- ## [0.85.52](0.85.51...0.85.52) (2023-12-20) ### Features * image build spec ([#1964](#1964)) ([367d13b](367d13b)) ### Bug Fixes * bring back old enclave continuity ([#1990](#1990)) ([723c81d](723c81d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>

tedim52 added 14 commits December 8, 2023 15:23

add image build spec starlark type

c8d4f64

add img build spec to service config

c94a54b

integrate img build spec with add service pt. 1

e7c12de

integrate img build spec with add service pt. 2

d87e03d

fix broken package content provider test

12a73c4

go tidy all

15428f5

add img builds to validation

2f42a64

add name to img build spec

a8b1ba6

add img build spec to builtins

7cf628f

adjust commment in service config

e3e8061

rename module content provider

2ad757c

remove validation for now

6f6310c

set built locally

607c2a1

downloading -> validating

f7ef134

tedim52 marked this pull request as draft December 15, 2023 05:52

tedim52 added 4 commits December 15, 2023 09:44

Merge branch 'main' into tedi/image-build-spec

77a0081

add back image building

161f033

Merge branch 'main' into tedi/image-build-spec

39d8590

remove bkclient dependency

dd5a6f7

tedim52 force-pushed the tedi/image-build-spec branch from cc58188 to ef9519c Compare December 15, 2023 15:58

remove flaky url test

7284765

tedim52 force-pushed the tedi/image-build-spec branch from ef9519c to 7284765 Compare December 15, 2023 16:11

go fmt kurtosis backend

af5cc42

tedim52 commented Dec 15, 2023

View reviewed changes

...ainer-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend.go Outdated Show resolved Hide resolved

tedim52 added 6 commits December 15, 2023 15:14

fix on disk path processing

ddf1a5c

add err handling for standalone scripts

acaaed4

refactor get on disk paths

e2992c0

return err when image build fails

47d0141

adjust comments

9b8a583

add validator funcs

2f97dee

add docs

d10b2a4

tedim52 added the user facing label Dec 19, 2023

tedim52 requested a review from leoporoli December 19, 2023 03:41

tedim52 marked this pull request as ready for review December 19, 2023 03:41

only run test over docker

1dda76c

tedim52 force-pushed the tedi/image-build-spec branch from 4e4d48f to 1dda76c Compare December 19, 2023 03:46

check if img is available

c39518f

tedim52 requested a review from adschwartz December 19, 2023 04:41